srowen commented on a change in pull request #20146: [SPARK-11215][ML] Add
multiple columns support to StringIndexer
URL: https://github.com/apache/spark/pull/20146#discussion_r245658271
##########
File path: R/pkg/tests/fulltests/test_mllib_regression.R
##########
@@ -102,10 +102,18 @@ test_that("spark.glm and predict", {
})
test_that("spark.glm summary", {
+ # prepare dataset
Review comment:
For coercing the cols to factors (we need that here?), is this shorter?
https://stackoverflow.com/a/33180265/64174 here you're repeating the data, and
repeating it several times.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
