srowen commented on a change in pull request #20146: [SPARK-11215][ML] Add
multiple columns support to StringIndexer
URL: https://github.com/apache/spark/pull/20146#discussion_r245674635
##########
File path: mllib/src/main/scala/org/apache/spark/ml/feature/StringIndexer.scala
##########
@@ -172,37 +274,77 @@ object StringIndexer extends
DefaultParamsReadable[StringIndexer] {
@Since("1.6.0")
override def load(path: String): StringIndexer = super.load(path)
+
+ // Returns a function used to sort strings by frequency (ascending or
descending).
+ // In case of equal frequency, it sorts strings by alphabet (ascending).
+ private[feature] def getSortFunc(
+ ascending: Boolean): ((String, Long), (String, Long)) => Boolean = {
+ if (ascending) {
+ (a: (String, Long), b: (String, Long)) => {
Review comment:
I think indent if off one space here. Can you write something like `((strA,
freqA), (strB, freqB)) =>` here for clarity? You could also write this
comparison once and then wrap it in something that flips the comparison if
`ascending` is `false`, but no big deal.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
