bart-samwel commented on a change in pull request #23388: [SPARK-26448][SQL]
retain the difference between 0.0 and -0.0
URL: https://github.com/apache/spark/pull/23388#discussion_r245778703
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/JoinSuite.scala
##########
@@ -909,4 +909,50 @@ class JoinSuite extends QueryTest with SharedSQLContext {
checkAnswer(df, Row(1, 100, 42, 200, 1, 42))
}
}
+
+ test("NaN and -0.0 in join keys") {
+ withTempView("v1", "v2", "v3", "v4") {
+ Seq(Float.NaN -> Double.NaN, 0.0f -> 0.0, -0.0f -> -0.0).toDF("f",
"d").createTempView("v1")
+ Seq(Float.NaN -> Double.NaN, 0.0f -> 0.0, -0.0f -> -0.0).toDF("f",
"d").createTempView("v2")
+
+ checkAnswer(
+ sql(
+ """
+ |SELECT v1.f, v1.d
Review comment:
Also select the v2 columns for clarity on why the result is what it is?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
