bart-samwel commented on a change in pull request #23388: [SPARK-26448][SQL] retain the difference between 0.0 and -0.0 URL: https://github.com/apache/spark/pull/23388#discussion_r246033456
########## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/NormalizeFloatingNumbers.scala ########## @@ -28,26 +28,30 @@ import org.apache.spark.sql.types._ * We need to take care of special floating numbers (NaN and -0.0) in several places: * 1. When compare values, different NaNs should be treated as same, `-0.0` and `0.0` should be * treated as same. - * 2. In GROUP BY, different NaNs should belong to the same group, -0.0 and 0.0 should belong - * to the same group. + * 2. In aggregate grouping keys, different NaNs should belong to the same group, -0.0 and 0.0 + * should belong to the same group. * 3. In join keys, different NaNs should be treated as same, `-0.0` and `0.0` should be Review comment: Still remove "different NaNs should be treated as same" here? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
