Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/3541#discussion_r21120040
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala ---
@@ -274,12 +274,12 @@ private[spark] class TaskSetManager(
* Is this re-execution of a failed task on an executor it already
failed in before
* EXECUTOR_TASK_BLACKLIST_TIMEOUT has elapsed ?
*/
- private def executorIsBlacklisted(execId: String, taskId: Int): Boolean
= {
- if (failedExecutors.contains(taskId)) {
- val failed = failedExecutors.get(taskId).get
+ private def executorIsBlacklisted(host: String, taskId: Int): Boolean = {
+ if (failedHosts.contains(taskId)) {
+ val hosts = failedHosts.get(taskId).get
- return failed.contains(execId) &&
- clock.getTime() - failed.get(execId).get <
EXECUTOR_TASK_BLACKLIST_TIMEOUT
+ return hosts.contains(host) &&
+ clock.getTime() - hosts.get(host).get <
EXECUTOR_TASK_BLACKLIST_TIMEOUT
--- End diff --
hm one thing that's ugly here is we should ideally change this to
HOST_TASK_BLACKLIST_TIMEOUT -- but then the name of the config variable is
inconsistent...any ideas for what makes most sense here?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
