Github user kayousterhout commented on a diff in the pull request:

    https://github.com/apache/spark/pull/3541#discussion_r21120179
  
    --- Diff: 
core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala ---
    @@ -79,8 +79,8 @@ private[spark] class TaskSetManager(
       val copiesRunning = new Array[Int](numTasks)
       val successful = new Array[Boolean](numTasks)
       private val numFailures = new Array[Int](numTasks)
    -  // key is taskId, value is a Map of executor id to when it failed
    -  private val failedExecutors = new HashMap[Int, HashMap[String, Long]]()
    +  // key is taskId, value is a Map of host to when it failed
    +  private val failedHosts = new HashMap[Int, HashMap[String, Long]]()
    --- End diff --
    
    can you change this to failedHostsForTask? I think that would make it more 
clear that the indices here are task ids (realize this isn't directly related 
to your change -- but would improve readability)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to