srowen commented on issue #20512: [SPARK-23182][CORE] Allow enabling TCP keep alive on the master RPC connections. URL: https://github.com/apache/spark/pull/20512#issuecomment-452535631 My understanding is that there is a benefit for the master's RPC connections, as described in the PR description. The benefit or cost for other server connections is unclear; probably no harm other than a few extra messages on slow connection; probably no real upside. The argument for this change as-is is that it addresses the RPC master connection and just applies the setting consistently elsewhere, where it's probably neither positive nor negative. There is also an argument for making this change a little more complex to affect only the master RPCs, as described in the PR currently. I could live with either one.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
