srowen commented on issue #20512: [SPARK-23182][CORE] Allow enabling TCP keep alive on the master RPC connections. URL: https://github.com/apache/spark/pull/20512#issuecomment-452522808 @peshopetrov it looks like the TransportServer is used in two implementations of the shuffle service as well as the block transfer service, in addition to the RPC server. I think that's what people are getting at. I don't see an objection to setting keep-alive on all of these connections, so one resolution is just to change the JIRA/PR to reflect the fact that it's going to affect more than RPCs. Another resolution is to add new arguments or configs to make only the RPC server enable this new setting. That could be fine too. I personally would favor the first option; just update the description. I don't see an argument that there's substantial downside to enabling this for all of these server connections.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
