felixcheung commented on a change in pull request #23486: [SPARK-26457] Show
hadoop configurations in HistoryServer environment tab
URL: https://github.com/apache/spark/pull/23486#discussion_r246287530
##########
File path: core/src/main/scala/org/apache/spark/SparkEnv.scala
##########
@@ -442,9 +445,13 @@ object SparkEnv extends Logging {
val addedJarsAndFiles = (addedJars ++ addedFiles).map((_, "Added By User"))
val classPaths = (addedJarsAndFiles ++ classPathEntries).sorted
+ // Add Hadoop properties, it will ignore configs including in Spark
+ val hadoopProperties = hadoopConf.asScala.filter(entry =>
!conf.contains("spark.hadoop." + entry.getKey)).
Review comment:
I actually don't think we should filter them - if I am trying to debug why
the config is not getting picked up it's useful to see everyone listed here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
