Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/3238#discussion_r21121349
  
    --- Diff: 
yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ClientBase.scala ---
    @@ -223,10 +224,42 @@ private[spark] trait ClientBase extends Logging {
             }
           }
         }
    +
         if (cachedSecondaryJarLinks.nonEmpty) {
           sparkConf.set(CONF_SPARK_YARN_SECONDARY_JARS, 
cachedSecondaryJarLinks.mkString(","))
         }
     
    +    /**
    +     * Do the same for datanucleus jars, if they exist in spark home. Find 
all datanucleus-* jars,
    +     * copy them to the remote fs, and add them to the class path.
    --- End diff --
    
    We should elaborate on why we need to do this. Without context I would be 
totally confused why we need to treat these jars differently (and only in 
cluster mode)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to