Github user ksakellis commented on a diff in the pull request:
https://github.com/apache/spark/pull/3486#discussion_r21134086
--- Diff:
core/src/main/scala/org/apache/spark/executor/CoarseGrainedExecutorBackend.scala
---
@@ -50,10 +50,16 @@ private[spark] class CoarseGrainedExecutorBackend(
override def preStart() {
logInfo("Connecting to driver: " + driverUrl)
driver = context.actorSelection(driverUrl)
- driver ! RegisterExecutor(executorId, hostPort, cores)
+ driver ! RegisterExecutor(executorId, hostPort, cores, extractLogUrls)
context.system.eventStream.subscribe(self,
classOf[RemotingLifecycleEvent])
}
+ def extractLogUrls : Map[String, String] = {
+ val prefix = "SPARK_LOG_URL_"
--- End diff --
Well, we do this kind of "trickery" in spark already - parse out all env
variables that start with SPARK_ so this technique is nothing new. Because of
this, I don't see the harm in keeping this flexible so that if a cluster
manager wants to add other types of logs it can.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
