Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/3486#discussion_r21491005
  
    --- Diff: 
core/src/main/scala/org/apache/spark/scheduler/SparkListener.scala ---
    @@ -183,6 +193,16 @@ trait SparkListener {
        * Called when the driver receives task metrics from an executor in a 
heartbeat.
        */
       def onExecutorMetricsUpdate(executorMetricsUpdate: 
SparkListenerExecutorMetricsUpdate) { }
    +
    +  /**
    +   * Called when the driver registers a new executor.
    +   */
    +  def onExecutorAdded(executorAdded: SparkListenerExecutorAdded) { }
    --- End diff --
    
    Ah wait. I see. These methods have default implementations, so they'll only 
affect people extending `SparkListener` from Java. Still, we should probably 
save these events to the log for replay later.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to