imatiach-msft commented on a change in pull request #21632:
[SPARK-19591][ML][MLlib] Add sample weights to decision trees
URL: https://github.com/apache/spark/pull/21632#discussion_r246995929
##########
File path: project/MimaExcludes.scala
##########
@@ -241,7 +241,10 @@ object MimaExcludes {
// [SPARK-26216][SQL] Do not use case class as public API
(UserDefinedFunction)
ProblemFilters.exclude[MissingClassProblem]("org.apache.spark.sql.expressions.UserDefinedFunction$"),
-
ProblemFilters.exclude[IncompatibleTemplateDefProblem]("org.apache.spark.sql.expressions.UserDefinedFunction")
+
ProblemFilters.exclude[IncompatibleTemplateDefProblem]("org.apache.spark.sql.expressions.UserDefinedFunction"),
+
+ // [SPARK-19591][ML] Add sample weights to decision trees
+
ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.spark.mllib.tree.configuration.Strategy.this")
Review comment:
How can I make this work while still having the new BeanProperty? I've tried
creating a duplicate constructor but scala complained about duplicate
signatures:
```
/**
* Backwards compatible constructor for
[[org.apache.spark.mllib.tree.configuration.Strategy]]
*/
@Since("1.0.0")
def this(algo: Algo,
impurity: Impurity,
maxDepth: Int,
numClasses: Int,
maxBins: Int,
quantileCalculationStrategy: QuantileStrategy = Sort,
categoricalFeaturesInfo: Map[Int, Int] = Map[Int, Int](),
minInstancesPerNode: Int = 1,
minInfoGain: Double = 0.0,
maxMemoryInMB: Int = 256,
subsamplingRate: Double = 1,
useNodeIdCache: Boolean = false,
checkpointInterval: Int = 10
) {
this(algo, impurity, maxDepth, numClasses, maxBins,
quantileCalculationStrategy,
categoricalFeaturesInfo, minInstancesPerNode, minInfoGain,
maxMemoryInMB,
subsamplingRate, useNodeIdCache, checkpointInterval, 0.0)
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
