imatiach-msft commented on a change in pull request #21632:
[SPARK-19591][ML][MLlib] Add sample weights to decision trees
URL: https://github.com/apache/spark/pull/21632#discussion_r246996910
##########
File path: project/MimaExcludes.scala
##########
@@ -241,7 +241,10 @@ object MimaExcludes {
// [SPARK-26216][SQL] Do not use case class as public API
(UserDefinedFunction)
ProblemFilters.exclude[MissingClassProblem]("org.apache.spark.sql.expressions.UserDefinedFunction$"),
-
ProblemFilters.exclude[IncompatibleTemplateDefProblem]("org.apache.spark.sql.expressions.UserDefinedFunction")
+
ProblemFilters.exclude[IncompatibleTemplateDefProblem]("org.apache.spark.sql.expressions.UserDefinedFunction"),
+
+ // [SPARK-19591][ML] Add sample weights to decision trees
+
ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.spark.mllib.tree.configuration.Strategy.this")
Review comment:
here is an example of the error:
```
[error] val strategy = new Strategy(algo, impurity, maxDepth,
numClasses, maxBins,
[error] ^
[error]
/home/ilya/ilmat-spark/mllib/src/main/scala/org/apache/spark/mllib/tree/RandomForest.scala:170:
overloaded method constructor Strategy with alternatives:
[error] (algo:
org.apache.spark.mllib.tree.configuration.Algo.Algo,impurity:
org.apache.spark.mllib.tree.impurity.Impurity,maxDepth: Int,numClasses:
Int,maxBins: Int,quantileCalculationStrategy:
org.apache.spark.mllib.tree.configuration.QuantileStrategy.QuantileStrategy,categoricalFeaturesInfo:
Map[Int,Int],minInstancesPerNode: Int,minInfoGain: Double,maxMemoryInMB:
Int,subsamplingRate: Double,useNodeIdCache: Boolean,checkpointInterval:
Int)org.apache.spark.mllib.tree.configuration.Strategy <and>
[error] (algo:
org.apache.spark.mllib.tree.configuration.Algo.Algo,impurity:
org.apache.spark.mllib.tree.impurity.Impurity,maxDepth: Int,numClasses:
Int,maxBins: Int,quantileCalculationStrategy:
org.apache.spark.mllib.tree.configuration.QuantileStrategy.QuantileStrategy,categoricalFeaturesInfo:
Map[Int,Int],minInstancesPerNode: Int,minInfoGain: Double,maxMemoryInMB:
Int,subsamplingRate: Double,useNodeIdCache: Boolean,checkpointInterval:
Int,minWeightFractionPerNode:
Double)org.apache.spark.mllib.tree.configuration.Strategy
[error] cannot be applied to
(org.apache.spark.mllib.tree.configuration.Algo.Value,
org.apache.spark.mllib.tree.impurity.Impurity, Int, Int, Int,
org.apache.spark.mllib.tree.configuration.QuantileStrategy.Value, Map[Int,Int])
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
