cloud-fan commented on a change in pull request #23521: [SPARK-26604][CORE]
Register channel for stream request
URL: https://github.com/apache/spark/pull/23521#discussion_r247160790
##########
File path:
common/network-common/src/main/java/org/apache/spark/network/server/TransportRequestHandler.java
##########
@@ -127,6 +127,7 @@ private void processStreamRequest(final StreamRequest req)
{
ManagedBuffer buf;
try {
buf = streamManager.openStream(req.streamId);
+ streamManager.registerChannel(channel, req.streamId);
Review comment:
I'm wondering when we should do this. There are many kinds of requests, and
currently only chunk fetch request does it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
