cloud-fan commented on a change in pull request #23521: [SPARK-26604][CORE]
Register channel for stream request
URL: https://github.com/apache/spark/pull/23521#discussion_r247386999
##########
File path:
common/network-common/src/main/java/org/apache/spark/network/server/StreamManager.java
##########
@@ -70,6 +70,13 @@ public ManagedBuffer openStream(String streamId) {
*/
public void registerChannel(Channel channel, long streamId) { }
+ /**
+ * Associates a stream with a single client connection, which is guaranteed
to be the only reader
+ * of the stream. This is similar to {@link #registerChannel(Channel, long)}
method, but the
+ * <code>streamId</code> argument is for the stream in response to a
stream() request.
+ */
+ public void registerChannel(Channel channel, String streamId) { }
Review comment:
Now things get tricky here. There are 2 different kind of stream requests:
1. to download jar and other files
2. to fetch data blocks (introduced at #16989)
Which one do we need to register channel?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
