dongjoon-hyun commented on a change in pull request #23412: [SPARK-26477][CORE]
Use ConfigEntry for hardcoded configs for unsafe category
URL: https://github.com/apache/spark/pull/23412#discussion_r247336260
##########
File path: core/src/main/scala/org/apache/spark/internal/config/package.scala
##########
@@ -732,6 +732,21 @@ package object config {
.checkValue(v => v > 0, "The max failures should be a positive value.")
.createWithDefault(40)
+ private[spark] val UNSAFE_EXCEPTION_ON_MEMORY_LEAK =
+ ConfigBuilder("spark.unsafe.exceptionOnMemoryLeak")
+ .booleanConf
+ .createWithDefault(false)
+
+ private[spark] val UNSAFE_SORTER_SPILL_READ_AHEAD_ENABLED =
+ ConfigBuilder("spark.unsafe.sorter.spill.read.ahead.enabled")
+ .booleanConf
+ .createWithDefault(true)
+
+ private[spark] val UNSAFE_SORTER_SPILL_READER_BUFFER_SIZE =
+ ConfigBuilder("spark.unsafe.sorter.spill.reader.buffer.size")
+ .bytesConf(ByteUnit.BYTE)
+ .createWithDefault(1024 * 1024)
Review comment:
If possible, can we have a brief doc for the above new three configurations?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
