srowen commented on a change in pull request #23486: [SPARK-26457] Show hadoop
configurations in HistoryServer environment tab
URL: https://github.com/apache/spark/pull/23486#discussion_r247521171
##########
File path: core/src/main/scala/org/apache/spark/SparkEnv.scala
##########
@@ -442,9 +445,13 @@ object SparkEnv extends Logging {
val addedJarsAndFiles = (addedJars ++ addedFiles).map((_, "Added By User"))
val classPaths = (addedJarsAndFiles ++ classPathEntries).sorted
+ // Add Hadoop properties, it will not ignore configs including in Spark.
Some spark
+ // conf starting with "spark.hadoop" may overwrite it.
+ val hadoopProperties = hadoopConf.asScala.map(entry => (entry.getKey,
entry.getValue)).toSeq
Review comment:
I think `.asScala.toSeq` works directly too, no big deal
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
