srowen commented on a change in pull request #23486: [SPARK-26457] Show hadoop
configurations in HistoryServer environment tab
URL: https://github.com/apache/spark/pull/23486#discussion_r248314023
##########
File path: core/src/main/scala/org/apache/spark/ui/env/EnvironmentPage.scala
##########
@@ -70,26 +72,37 @@ private[ui] class EnvironmentPage(
<div class="aggregated-sparkProperties collapsible-table">
{sparkPropertiesTable}
</div>
+ <span class="collapse-aggregated-hadoopProperties collapse-table"
+ onClick="collapseTable('collapse-aggregated-hadoopProperties',
+ 'aggregated-hadoopProperties')">
+ <h4>
+ <span class="collapse-table-arrow arrow-closed"></span>
+ <a>Hadoop Properties</a>
+ </h4>
+ </span>
+ <div class="aggregated-hadoopProperties collapsible-table collapsed">
+ {hadoopPropertiesTable}
+ </div>
<span class="collapse-aggregated-systemProperties collapse-table"
onClick="collapseTable('collapse-aggregated-systemProperties',
'aggregated-systemProperties')">
<h4>
- <span class="collapse-table-arrow arrow-open"></span>
+ <span class="collapse-table-arrow arrow-closed"></span>
<a>System Properties</a>
</h4>
</span>
- <div class="aggregated-systemProperties collapsible-table">
+ <div class="aggregated-systemProperties collapsible-table collapsed">
Review comment:
Nice, so only the Spark properties and system info are expanded by default?
that sounds good.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
