cloud-fan commented on a change in pull request #23521: [SPARK-26604][CORE]
Clean up channel registration for StreamManager
URL: https://github.com/apache/spark/pull/23521#discussion_r247766122
##########
File path:
common/network-common/src/main/java/org/apache/spark/network/server/OneForOneStreamManager.java
##########
@@ -71,15 +71,22 @@ public OneForOneStreamManager() {
streams = new ConcurrentHashMap<>();
}
- @Override
+
+ /**
+ * Associates a stream with a single client connection, which is guaranteed
to be the only reader
+ * of the stream. Once the connection is closed, the stream will never be
used again, enabling
+ * cleanup by `connectionTerminated`.
+ */
public void registerChannel(Channel channel, long streamId) {
Review comment:
this can be private?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
