cloud-fan commented on a change in pull request #23521: [SPARK-26604][CORE]
Clean up channel registration for StreamManager
URL: https://github.com/apache/spark/pull/23521#discussion_r247766844
##########
File path:
common/network-common/src/main/java/org/apache/spark/network/server/StreamManager.java
##########
@@ -42,9 +42,10 @@
* The returned ManagedBuffer will be release()'d after being written to the
network.
*
* @param streamId id of a stream that has been previously registered with
the StreamManager.
+ * @param channel The connection used to serve chunk request.
Review comment:
let's say more about this parameter, especially how it should be used. IIUC
we need to track the channel states, and do some cleanup if the channel is
inactive.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
