GitHub user suyanNone opened a pull request:

    https://github.com/apache/spark/pull/3574

    [SPARK-4714][CORE]: Add checking info is null or not while having gotten 
info.syn

    [SPARK-4714][CORE]: Add checking info is null or not while having gotten 
info.syn
    in removeBlock()/ dropOldBlock()/ dropFromMemory()
    all have the same logic:
    1. info = blockInfo.get(id)
    2. if (info != null)
    3. info.synchronized
    there may be a possibility that while one thread got info.lock while the 
previous thread already removed from blockinfo in info.lock.
    but one thing in current code, That not check info is null or not, while 
getting info.lock to remove block, will not cause any errors.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/suyanNone/spark refine-block-concurrency

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/3574.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3574
    
----
commit e57e270906da88599cd240bff3d0fce6334bd954
Author: hushan[胡珊] <[email protected]>
Date:   2014-12-03T07:19:50Z

    add check info is already remove or not while having gotten info.syn

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to