Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/3574#discussion_r21418593
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
---
@@ -1089,15 +1089,17 @@ private[spark] class BlockManager(
val info = blockInfo.get(blockId).orNull
if (info != null) {
info.synchronized {
- // Removals are idempotent in disk store and memory store. At
worst, we get a warning.
- val removedFromMemory = memoryStore.remove(blockId)
- val removedFromDisk = diskStore.remove(blockId)
- val removedFromTachyon = if (tachyonInitialized)
tachyonStore.remove(blockId) else false
- if (!removedFromMemory && !removedFromDisk && !removedFromTachyon)
{
- logWarning(s"Block $blockId could not be removed as it was not
found in either " +
- "the disk, memory, or tachyon store")
+ if (blockInfo.get(blockId).isEmpty) {
--- End diff --
I don't think that this extra check is necessary; check out my comment on
the main pull request and see if you agree.
Even if we did want to add a check here, I think we want to check for
`if(blockInfo.get(blockId).nonEmpty)`, since this branch handles the case where
blocks have _not_ been removed already.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
