srowen commented on a change in pull request #23617: [SPARK-26680][SQL] Eagerly
create inputVars while conditions are appropriate
URL: https://github.com/apache/spark/pull/23617#discussion_r249821292
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala
##########
@@ -159,6 +156,10 @@ trait CodegenSupport extends SparkPlan {
BoundReference(i, attr.dataType, attr.nullable).genCode(ctx)
}
}
+ } match {
Review comment:
I think this construction is confusing. Can this be split into two
statements rather than chain a block and match?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
