vanzin commented on a change in pull request #23260: [SPARK-26311][CORE] New
feature: apply custom log URL pattern for executor log URLs in SHS
URL: https://github.com/apache/spark/pull/23260#discussion_r250012338
##########
File path: core/src/main/scala/org/apache/spark/status/api/v1/api.scala
##########
@@ -106,7 +106,17 @@ class ExecutorSummary private[spark](
val blacklistedInStages: Set[Int],
@JsonSerialize(using = classOf[ExecutorMetricsJsonSerializer])
@JsonDeserialize(using = classOf[ExecutorMetricsJsonDeserializer])
- val peakMemoryMetrics: Option[ExecutorMetrics])
+ val peakMemoryMetrics: Option[ExecutorMetrics],
+ val attributes: Map[String, String]) {
+
+ def replaceExecutorLogs(newExecutorLogs: Map[String, String]):
ExecutorSummary = {
Review comment:
At least `private[spark]`. But I'd prefer either:
- put this in the (only) class that's calling it
- make this a case class and use the `copy` method instead.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
