vanzin commented on a change in pull request #23260: [SPARK-26311][CORE] New
feature: apply custom log URL pattern for executor log URLs in SHS
URL: https://github.com/apache/spark/pull/23260#discussion_r250012751
##########
File path:
core/src/test/scala/org/apache/spark/deploy/history/FsHistoryProviderSuite.scala
##########
@@ -291,6 +292,159 @@ class FsHistoryProviderSuite extends SparkFunSuite with
BeforeAndAfter with Matc
}
}
+ test("Handling executor log url without renewing") {
Review comment:
renewing?
I also dislike this style of test name. Every test name starts with the same
prefix, which makes it hard to differentiate them.
To follow the pattern used in this class, for example:
```
test("log urls without customization")
test("custom log urls")
test("custom log urls with invalid attribute")
```
etc etc
If your test name is wrapping to the next line, it's too long.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
