cloud-fan commented on a change in pull request #23619: [SPARK-26695][SQL] data
source v2 API refactor - continuous read
URL: https://github.com/apache/spark/pull/23619#discussion_r250040594
##########
File path:
external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaContinuousStream.scala
##########
@@ -67,27 +72,40 @@ class KafkaContinuousReadSupport(
offsets
}
- override def fullSchema(): StructType = KafkaOffsetReader.kafkaSchema
-
- override def newScanConfigBuilder(start: Offset): ScanConfigBuilder = {
- new KafkaContinuousScanConfigBuilder(fullSchema(), start, offsetReader,
reportDataLoss)
- }
-
override def deserializeOffset(json: String): Offset = {
KafkaSourceOffset(JsonUtils.partitionOffsets(json))
}
- override def planInputPartitions(config: ScanConfig): Array[InputPartition]
= {
- val startOffsets =
config.asInstanceOf[KafkaContinuousScanConfig].startOffsets
+ override def planInputPartitions(start: Offset): Array[InputPartition] = {
+ val oldStartPartitionOffsets = KafkaSourceOffset.getPartitionOffsets(start)
Review comment:
moved from
https://github.com/apache/spark/pull/23619/files#diff-75718e2fd0d84469b882e6db9896e1b8L162
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
