cloud-fan commented on a change in pull request #23619: [SPARK-26695][SQL] data
source v2 API refactor - continuous read
URL: https://github.com/apache/spark/pull/23619#discussion_r250041252
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/continuous/ContinuousExecution.scala
##########
@@ -144,63 +158,33 @@ class ContinuousExecution(
* @param sparkSessionForQuery Isolated [[SparkSession]] to run the
continuous query with.
*/
private def runContinuous(sparkSessionForQuery: SparkSession): Unit = {
- // A list of attributes that will need to be updated.
- val replacements = new ArrayBuffer[(Attribute, Attribute)]
- // Translate from continuous relation to the underlying data source.
- var nextSourceId = 0
- continuousSources = logicalPlan.collect {
- case ContinuousExecutionRelation(dataSource, extraReaderOptions, output)
=>
- val metadataPath = s"$resolvedCheckpointRoot/sources/$nextSourceId"
- nextSourceId += 1
-
- dataSource.createContinuousReadSupport(
Review comment:
ditto, with the new abstraction, we should create the `ContinuousStream` at
the beginning of the `ContinuousExecution`, instead of each reconfiguration.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
