liupc commented on a change in pull request #23445: [SPARK-26530]Validate heartheat arguments in HeartbeatReceiver URL: https://github.com/apache/spark/pull/23445#discussion_r250069316
########## File path: core/src/main/scala/org/apache/spark/HeartbeatReceiver.scala ########## @@ -79,6 +79,17 @@ private[spark] class HeartbeatReceiver(sc: SparkContext, clock: Clock) private val checkTimeoutIntervalMs = sc.conf.get(Network.NETWORK_TIMEOUT_INTERVAL) + private val executorHeartbeatIntervalMs = sc.conf.get(config.EXECUTOR_HEARTBEAT_INTERVAL) + + require(checkTimeoutIntervalMs < executorTimeoutMs, Review comment: Anyway, I will update as your suggestion for I can't find a better way to make this log more clear. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
