liupc commented on a change in pull request #23445: [SPARK-26530]Validate
heartheat arguments in HeartbeatReceiver
URL: https://github.com/apache/spark/pull/23445#discussion_r250452204
##########
File path: core/src/main/scala/org/apache/spark/HeartbeatReceiver.scala
##########
@@ -79,6 +79,15 @@ private[spark] class HeartbeatReceiver(sc: SparkContext,
clock: Clock)
private val checkTimeoutIntervalMs =
sc.conf.get(Network.NETWORK_TIMEOUT_INTERVAL)
+ private val executorHeartbeatIntervalMs =
sc.conf.get(config.EXECUTOR_HEARTBEAT_INTERVAL)
+
+ require(checkTimeoutIntervalMs <= executorTimeoutMs,
+ s"${Network.NETWORK_TIMEOUT_INTERVAL.key} should be less than or " +
+ s"equal to ${config.STORAGE_BLOCKMANAGER_SLAVE_TIMEOUT.key}.")
+ require(executorHeartbeatIntervalMs < executorTimeoutMs,
Review comment:
@srowen done!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
