mgaido91 commented on a change in pull request #23531: [SPARK-24497][SQL] 
Support recursive SQL query
URL: https://github.com/apache/spark/pull/23531#discussion_r250142997
 
 

 ##########
 File path: sql/core/src/test/resources/sql-tests/inputs/recursion.sql
 ##########
 @@ -0,0 +1,291 @@
+-- List of configuration the test suite is run against:
 
 Review comment:
   I am not sure about your approach to LIMIT. I see that you put the TODO for 
it in the execution. I think instead we are just missing the pushdown which 
should be done in the analysis/optimization phase. Have you tried this way/or 
did you foresee issues for which you discarded this approach? I'd consider very 
bad starting handling specific case at execution phase.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to