rvesse commented on a change in pull request #23613: [SPARK-26687][K8S] Fix
handling of custom Dockerfile paths
URL: https://github.com/apache/spark/pull/23613#discussion_r250145136
##########
File path: bin/docker-image-tool.sh
##########
@@ -67,6 +67,16 @@ function docker_push {
fi
}
+function resolve_file {
+ local FILE=$1
+ if [ -n "$FILE" ]; then
+ local DIR=$(dirname $FILE)
Review comment:
Which doesn't work on OS X/BSD where `-f` is a format specifier not follow
links
Also the intent was not to attempt to resolve symbolic links simply to make
the path absolute so the `cd` into the build context directory doesn't render
the relative path invalid
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
