srowen commented on a change in pull request #23641: [SPARK-26719][SQL] Get rid
of java.util.Calendar in DateTimeUtils
URL: https://github.com/apache/spark/pull/23641#discussion_r250835731
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/util/DateTimeTestUtils.scala
##########
@@ -17,12 +17,16 @@
package org.apache.spark.sql.catalyst.util
+import java.time.{LocalDate, LocalDateTime, LocalTime}
import java.util.TimeZone
+import java.util.concurrent.TimeUnit
+
+import org.apache.spark.sql.catalyst.util.DateTimeUtils.TimeZoneUTC
/**
* Helper functions for testing date and time functionality.
*/
-object DateTimeTestUtils {
+trait DateTimeTestUtils {
Review comment:
Does it need to become a trait? not against it but I didn't see why it was
needed from skimming this. Is it just convenience?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
