devaraj-kavali commented on a change in pull request #19616:
[SPARK-22404][YARN] Provide an option to use unmanaged AM in yarn-client mode
URL: https://github.com/apache/spark/pull/19616#discussion_r250837447
##########
File path:
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala
##########
@@ -298,6 +281,60 @@ private[spark] class ApplicationMaster(args:
ApplicationMasterArguments) extends
exitCode
}
+ def runUnmanaged(
+ clientRpcEnv: RpcEnv,
+ appAttemptId: ApplicationAttemptId,
+ stagingDir: Path,
+ cachedResourcesConf: SparkConf): Unit = {
+ try {
+ new CallerContext(
+ "APPMASTER", sparkConf.get(APP_CALLER_CONTEXT),
+ Option(appAttemptId.getApplicationId.toString),
None).setCurrentContext()
+
+ val driverRef = clientRpcEnv.setupEndpointRef(
+ RpcAddress(sparkConf.get("spark.driver.host"),
+ sparkConf.get("spark.driver.port").toInt),
+ YarnSchedulerBackend.ENDPOINT_NAME)
+ // The client-mode AM doesn't listen for incoming connections, so report
an invalid port.
+ registerAM(Utils.localHostName, -1, sparkConf,
+ sparkConf.getOption("spark.driver.appUIAddress"), appAttemptId)
+ addAmIpFilter(Some(driverRef),
ProxyUriUtils.getPath(appAttemptId.getApplicationId))
+ createAllocator(driverRef, sparkConf, clientRpcEnv, appAttemptId,
cachedResourcesConf)
+ reporterThread.join()
+ } catch {
+ case e: Exception =>
+ // catch everything else if not specifically handled
+ logError("Uncaught exception: ", e)
+ finish(FinalApplicationStatus.FAILED,
+ ApplicationMaster.EXIT_UNCAUGHT_EXCEPTION,
+ "Uncaught exception: " + StringUtils.stringifyException(e))
+ if (!unregistered) {
Review comment:
`appMaster.runUnmanaged` is running in a daemon thread, if something goes
unexpected in `appMaster.runUnmanaged` then the daemon thread stops and monitor
thread will not know about it and continue with the status as ACCEPTED/RUNNING,
this code unregisters with RM so that the Client/monitor thread gets the
application report status as FAILED and stops the services including `sc`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
