cloud-fan commented on a change in pull request #23645: [SPARK-26725][TEST] Fix 
the input values of UnifiedMemoryManager constructor in test suites
URL: https://github.com/apache/spark/pull/23645#discussion_r251013928
 
 

 ##########
 File path: 
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashedRelation.scala
 ##########
 @@ -97,7 +97,7 @@ private[execution] object HashedRelation {
         new UnifiedMemoryManager(
           new SparkConf().set(MEMORY_OFFHEAP_ENABLED.key, "false"),
           Long.MaxValue,
-          Long.MaxValue,
+          Long.MaxValue / 2,
 
 Review comment:
   shall we add an assert in `UnifiedMemoryManager` to make sure execution 
memory is > 0?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to