cloud-fan commented on a change in pull request #23645: [SPARK-26725][TEST] Fix
the input values of UnifiedMemoryManager constructor in test suites
URL: https://github.com/apache/spark/pull/23645#discussion_r251037860
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashedRelation.scala
##########
@@ -230,7 +230,7 @@ private[joins] class UnsafeHashedRelation(
new UnifiedMemoryManager(
new SparkConf().set(MEMORY_OFFHEAP_ENABLED.key, "false"),
Long.MaxValue,
- Long.MaxValue,
+ Long.MaxValue / 2,
Review comment:
note: This actually doesn't matter. It's a dummy memory manager which is
only used to create the `BytesToBytesMap`. This memory manager will not consume
any storage memory, which means the execution memory can grow until it takes
all the memory, which is `Long.MaxValue`.
Anyway, it's still better to make sure the values are not nonsense.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
