cloud-fan commented on a change in pull request #23438:
[SPARK-26525][SHUFFLE]Fast release ShuffleBlockFetcherIterator on completion of
the iteration
URL: https://github.com/apache/spark/pull/23438#discussion_r251745683
##########
File path:
core/src/main/scala/org/apache/spark/storage/ShuffleBlockFetcherIterator.scala
##########
@@ -219,6 +221,10 @@ final class ShuffleBlockFetcherIterator(
logWarning("Failed to cleanup shuffle fetch temp file " + file.path())
}
}
+ // Null out the referent in cleanup listener to make sure we don't keep a
reference
+ // to this ShuffleBlockFetcherIterator, after we're done reading from it,
to let it be
Review comment:
can you point out where `ShuffleBlockFetcherIterator` occupies a large
amount of memory?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
