cloud-fan commented on a change in pull request #23438:
[SPARK-26525][SHUFFLE]Fast release ShuffleBlockFetcherIterator on completion of
the iteration
URL: https://github.com/apache/spark/pull/23438#discussion_r252103162
##########
File path:
core/src/main/scala/org/apache/spark/storage/ShuffleBlockFetcherIterator.scala
##########
@@ -160,6 +160,8 @@ final class ShuffleBlockFetcherIterator(
@GuardedBy("this")
private[this] val shuffleFilesSet = mutable.HashSet[DownloadFile]()
+ private[this] var onCompleteCallback: ShuffleFetchCompletionListener = _
Review comment:
shall we create the listener here and mark it as a `val`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
