squito commented on a change in pull request #22806: [SPARK-25250][CORE] : Late
zombie task completions handled correctly even before new taskset launched
URL: https://github.com/apache/spark/pull/22806#discussion_r251914784
##########
File path:
core/src/test/scala/org/apache/spark/scheduler/TaskSchedulerImplSuite.scala
##########
@@ -1102,110 +1102,6 @@ class TaskSchedulerImplSuite extends SparkFunSuite
with LocalSparkContext with B
}
}
- test("Completions in zombie tasksets update status of non-zombie taskset") {
Review comment:
sorry I may have been vague in my prior comments
(https://github.com/apache/spark/pull/22806/files#r250354836) but I really
think we need to keep this test. The new test you're adding in
DAGSchedulerSuite has all of the TaskScheduler / TaskSetManager stuff mocked
out, so its not verifying enough. Does it not pass with the other changes? You
might need to update it within the Suite here
https://github.com/apache/spark/blob/master/core/src/test/scala/org/apache/spark/scheduler/TaskSchedulerImplSuite.scala#L115
?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
