srowen commented on a change in pull request #23676: [SPARK-26754][PYTHON] Add
hasTrainingSummary to replace duplicate code in PySpark
URL: https://github.com/apache/spark/pull/23676#discussion_r252302802
##########
File path: python/pyspark/ml/util.py
##########
@@ -611,3 +611,33 @@ def loadParamsInstance(path, sc):
py_type = DefaultParamsReader.__get_class(pythonClassName)
instance = py_type.load(path)
return instance
+
+
+@inherit_doc
+class HasTrainingSummary(object):
+ """
+ Base class for models that provides Training summary.
+ .. versionadded:: 3.0.0
+ """
+
+ @property
+ @since("3.0.0")
Review comment:
The only issue I see here is that these properties were effectively added to
subclasses in 2.0.0 and 2.1.0, so this seems somewhat misleading. Maybe we can
declare these "since 2.1.0" as close enough?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
