srowen commented on a change in pull request #23676: [SPARK-26754][PYTHON] Add
hasTrainingSummary to replace duplicate code in PySpark
URL: https://github.com/apache/spark/pull/23676#discussion_r252909748
##########
File path: python/pyspark/ml/classification.py
##########
@@ -532,24 +533,16 @@ def summary(self):
trained on the training set. An exception is thrown if
`trainingSummary is None`.
"""
if self.hasSummary:
Review comment:
Pardon if you were already going to follow up on this, but I think you don't
need to check self.hasSummary here and other classes anymore. The
implementation in the new trait can do that in one place.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
