maasg commented on issue #21194: [SPARK-24046][SS] Fix rate source when 
rowsPerSecond <= rampUpTime  
URL: https://github.com/apache/spark/pull/21194#issuecomment-458997326
 
 
   @gaborgsomogyi Thanks for your comment. This PR is not about smoothing the 
curve. That's a side-effect --which I think is a benefit--
   This PR is about fixing the rate source when `rowsPerSecond <= rampUpTime`, 
which results in 0 rows for the whole period `[0, rampUpTime)`, as illustrated 
here:
   
![image-2018-04-22-22-06-49-202](https://user-images.githubusercontent.com/874997/51993649-8de54380-24af-11e9-8b22-04891903ecd3.png)
   
   This is clearly a bug. 
   This has been frozen, as I do not agree with the reviewers that the existing 
behavior when `rowsPerSecond > rampUpTime` should not change. This PR presents 
a behavior that is clearly more consistent that the existing implementation: 
   
   ### Existing:
   
![existing](https://user-images.githubusercontent.com/874997/51993808-dc92dd80-24af-11e9-9c73-93ee7c36fefa.png)
   ### This PR:
   
![thispr-ramp-up](https://user-images.githubusercontent.com/874997/51993817-e288be80-24af-11e9-91d2-6950256e0dbd.png)
   
   What do you think should happen here?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to