maasg edited a comment on issue #21194: [SPARK-24046][SS] Fix rate source when rowsPerSecond <= rampUpTime URL: https://github.com/apache/spark/pull/21194#issuecomment-458997326 @gaborgsomogyi Thanks for your comment. This PR is not about smoothing the curve. That's a side-effect --which I think is a benefit-- This PR is about fixing the rate source when `rowsPerSecond <= rampUpTime`, which results in 0 rows for the whole period `[0, rampUpTime)`, as illustrated here:  This is clearly a bug. This has PR has been frozen in review, as I do not agree with the reviewers that the existing behavior when `rowsPerSecond > rampUpTime` should not change. This PR presents a behavior that is clearly more consistent than the existing implementation: ### Existing:  ### This PR:  Patching the rate-computing formula exclusively for the case of `rowsPerSecond <= rampUpTime` will result in fairly ugly code. What do you think should happen here?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
