Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/3635#discussion_r21526232
--- Diff:
core/src/main/scala/org/apache/spark/storage/DiskBlockManager.scala ---
@@ -67,11 +67,29 @@ private[spark] class DiskBlockManager(blockManager:
BlockManager, conf: SparkCon
if (subDir == null) {
subDir = subDirs(dirId).synchronized {
val old = subDirs(dirId)(subDirId)
- if (old != null) {
+ if (old != null && old.exists()) {
old
} else {
+ var foundLocalDir = false
+ var tries = 0
val newDir = new File(localDirs(dirId), "%02x".format(subDirId))
- newDir.mkdir()
+ while (!foundLocalDir && tries < MAX_DIR_CREATION_ATTEMPTS) {
+ tries += 1
+ try {
+ if (!newDir.exists()) {
+ foundLocalDir = newDir.mkdir()
+ }
+ else {
+ foundLocalDir = true
+ }
+ } catch {
+ case e: Exception =>
+ logWarning(s"Attempt $tries to create local dir $newDir
failed", e)
+ }
+ }
+ if (!foundLocalDir) {
+ throw new Exception(s"Failed $MAX_DIR_CREATION_ATTEMPTS
attempts to create local dir in $newDir.")
--- End diff --
`IOException` is more appropriate.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
