Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/3635#discussion_r21875371
--- Diff:
core/src/main/scala/org/apache/spark/storage/DiskBlockManager.scala ---
@@ -67,11 +67,13 @@ private[spark] class DiskBlockManager(blockManager:
BlockManager, conf: SparkCon
if (subDir == null) {
subDir = subDirs(dirId).synchronized {
val old = subDirs(dirId)(subDirId)
- if (old != null) {
+ if (old != null && old.exists()) {
old
} else {
val newDir = new File(localDirs(dirId), "%02x".format(subDirId))
- newDir.mkdir()
+ if (!newDir.exists() && !newDir.mkdir()) {
--- End diff --
One thing to note is that `mkdir` returns `false` if the directory already
existed, which shouldn't be an error (?). I'm not familiar enough with the code
to know if this should ever be possible in normal operation. But maybe the
defensive check here is fine.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
