gatorsmile commented on issue #23607: [SPARK-26681][SQL] Support Ammonite inner-class scopes. URL: https://github.com/apache/spark/pull/23607#issuecomment-459057042 @srowen What is our policy for supporting third-party library? The community has many third-party library. Did we merge anything before? Merging this PR sounds an exception to me. No test coverage and no documentation about the support. I would ping more people before merging such a PR, if we are not confident about the PR. Although ammonite is developed by our teammate Haoyi, I still prefer to having a broader discussion first. Supporting ammonite sounds not trivial. I do not expect we will maintain the support, especially when ammonite-spark has a walkaround. Also, ammonite-spark sounds has a limitation for supporting ammonite.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
