Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/3486#discussion_r21564474
--- Diff:
yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ExecutorRunnableUtil.scala
---
@@ -179,7 +178,7 @@ trait ExecutorRunnableUtil extends Logging {
localResources
}
- def prepareEnvironment: HashMap[String, String] = {
+ def prepareEnvironment(container : Container): HashMap[String, String] =
{
--- End diff --
This could just take in `containerId`. It would also be very, very nice if
you could add the java docs to this method (not necessarily related to this
patch but it would be great to incrementally improve the documentation in this
corner of the Spark code)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
