Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/3194#discussion_r21579370
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/HistoryPage.scala ---
@@ -51,10 +52,7 @@ private[spark] class HistoryPage(parent: HistoryServer)
extends WebUIPage("") {
if (allApps.size > 0) {
<h4>
Showing {actualFirst + 1}-{last + 1} of {allApps.size}
- <span style="float: right">
- {if (actualPage > 1) <a href={"/?page=" + (actualPage -
1)}><</a>}
- {if (actualPage < pageCount) <a href={"/?page=" +
(actualPage + 1)}>></a>}
- </span>
+ {pageIndices(pageCount, actualPage)}
--- End diff --
Minor, but I actually think this doesn't need to be in its own method. It's
probably clearer if the HTML is in here directly. Right now it's not clear why
it's floating right from first glance.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
