Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/3194#discussion_r21579476
  
    --- Diff: 
core/src/main/scala/org/apache/spark/deploy/history/HistoryPage.scala ---
    @@ -51,10 +52,7 @@ private[spark] class HistoryPage(parent: HistoryServer) 
extends WebUIPage("") {
                 if (allApps.size > 0) {
                   <h4>
                     Showing {actualFirst + 1}-{last + 1} of {allApps.size}
    -                <span style="float: right">
    -                  {if (actualPage > 1) <a href={"/?page=" + (actualPage - 
1)}>&lt;</a>}
    -                  {if (actualPage < pageCount) <a href={"/?page=" + 
(actualPage + 1)}>&gt;</a>}
    -                </span>
    +                  {pageIndices(pageCount, actualPage)}
    --- End diff --
    
    Could you also add some comment here that says something like
    ```
    // This displays the indices of pages that are within `plusOrMinus` pages 
of the current page
    // Regardless of where the current page is, this also links to the first 
and last page
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to