srowen commented on a change in pull request #20793: [WIP][SPARK-23643]
Shrinking the buffer in hashSeed up to size of the seed parameter
URL: https://github.com/apache/spark/pull/20793#discussion_r255303183
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/DataFrameStatSuite.scala
##########
@@ -47,7 +47,7 @@ class DataFrameStatSuite extends QueryTest with
SharedSQLContext {
val data = sparkContext.parallelize(1 to n, 2).toDF("id")
checkAnswer(
data.sample(withReplacement = false, 0.05, seed = 13),
- Seq(3, 17, 27, 58, 62).map(Row(_))
+ Seq(37, 8, 90).map(Row(_))
Review comment:
While these tests 'overfit', I think it's fine to do what you have done here
to update them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
